Closed nickkaczmarek closed 7 years ago
@tsriram Any reason you didn't want this in there?
@Nickkaczmarek just left a couple of questions in the review section...would you please clarify?
@tsriram I don't see a review section on my side.
@Nickkaczmarek strange. Don't you see it when you go to Files changed
tab in this PR?
Files changed
Ah, anything when you click on Review changes
?
Btw, this is what I posted:
This is what I see
Also, I'll look into those questions after work tonight or later this week. Testing these things is important.
Cool. These should be visible in Commits
tab then.
Yup, testing these things is very important. I'm quite not sure how to go about automating this testing. Do let me know if you have any ideas.
@tsriram Did you do all of this?
https://help.github.com/articles/reviewing-proposed-changes-in-a-pull-request/
Lol, I thought adding a comment would automatically show up. Sorry man. Have submitted it now.
I didn't realize it was such an involved process. You're good. I'm new to this whole PR on github thing. I've only done these at work before.
Hey @tsriram,
I updated the color to match this:
Thank you @Nickkaczmarek :)
Explanation This change modifies the background color on the moment items to make them grey and the text white. I also fixed an issue where you couldn't see the @username of a person in the capsule.
Capsule color changes
Capsules with light inner moments change