tsriram / twitter-web-night-mode

Chrome / Firefox extension for twitter's night mode
https://tsriram.in/2017/09/24/retiring-twitter-web-night-mode-extension/
MIT License
49 stars 15 forks source link

Feature/moments capsule updates #45

Closed nickkaczmarek closed 7 years ago

nickkaczmarek commented 7 years ago

Explanation This change modifies the background color on the moment items to make them grey and the text white. I also fixed an issue where you couldn't see the @username of a person in the capsule.

Capsule color changes

before_lighter_capsules after_darker_capsules

Capsules with light inner moments change

before_light_moment after_darker_moment
nickkaczmarek commented 7 years ago

@tsriram Any reason you didn't want this in there?

tsriram commented 7 years ago

@Nickkaczmarek just left a couple of questions in the review section...would you please clarify?

nickkaczmarek commented 7 years ago

@tsriram I don't see a review section on my side.

tsriram commented 7 years ago

@Nickkaczmarek strange. Don't you see it when you go to Files changed tab in this PR?

nickkaczmarek commented 7 years ago

@tsriram This is what I see when I go to Files changed

capture

tsriram commented 7 years ago

Ah, anything when you click on Review changes?

Btw, this is what I posted:

image

nickkaczmarek commented 7 years ago

This is what I see capture2

Also, I'll look into those questions after work tonight or later this week. Testing these things is important.

tsriram commented 7 years ago

Cool. These should be visible in Commits tab then.

Yup, testing these things is very important. I'm quite not sure how to go about automating this testing. Do let me know if you have any ideas.

nickkaczmarek commented 7 years ago

@tsriram Did you do all of this?

https://help.github.com/articles/reviewing-proposed-changes-in-a-pull-request/

tsriram commented 7 years ago

Lol, I thought adding a comment would automatically show up. Sorry man. Have submitted it now.

nickkaczmarek commented 7 years ago

I didn't realize it was such an involved process. You're good. I'm new to this whole PR on github thing. I've only done these at work before.

nickkaczmarek commented 7 years ago

Hey @tsriram,

I updated the color to match this:

img_1792

tsriram commented 7 years ago

Thank you @Nickkaczmarek :)