search

tsroten / dragonmapper

Identification and conversion functions for Chinese text processing
MIT License
54 stars 18 forks source link

update tutorial to explitly show the need for unicode strings #12

Closed astromme closed 8 years ago

astromme commented 8 years ago

fixes https://github.com/tsroten/dragonmapper/issues/11

tsroten commented 8 years ago

@astromme Thank you for the pull request. Seriously, I appreciate it.

Python 3 has been out for 7 years now. I'm hesitant to make the examples target Python 2, even though the u-prefix works in Python 3.

That being said, I like the idea of helping new users out who might still be using Python 2. Instead of updating every example, how about we put a simple note in the first paragraph of the tutorial that reminds users who have Python 2 to prefix their strings with a u? It could also link to the Python 2 Unicode HOWTO (unicode literals section).

astromme commented 8 years ago

Sure thing. Updated pull request in #13.