search

tsroten / pynlpir

A Python wrapper around the NLPIR/ICTCLAS Chinese segmentation software.
MIT License
566 stars 135 forks source link

Update pos_map.py #125

Closed KoichiYasuoka closed 5 years ago

KoichiYasuoka commented 5 years ago

Some quick hacks for issue #82

tsroten commented 5 years ago

@KoichiYasuoka Thanks for the pull request! I like the raw idea 👍

It looks like there are two tests that are failing. Would you be able to update these?

In the file tests/test_pos_map.py, on line 78, it's expecting None to be returned (and that's what we want to test for). So, gms should likely be changed to another value that does not exist in the POS mapping.

Also, in tests/test_init.py, line 124, 甲 should be updated from numeral to numeral:zodiac.

KoichiYasuoka commented 5 years ago

I've rewritten test_init.py and test_pos.map.py as indicated, but "All checks have failed". Umm...

tsroten commented 5 years ago

@KoichiYasuoka The related tests are passing again 👍 It appears the other errors in the tests are unrelated (one is a broken URL in the documentation). I'll fix those separately.

Thanks again for your contribution! Do you mind if I add your name to the contributors list with a link to your GitHub profile?

KoichiYasuoka commented 5 years ago

Thank you @tsroten for merging, and I'm looking forward to see my name on the contributors. Also I'm looking forward to the update of pip installer.

tsroten commented 5 years ago

@KoichiYasuoka Thanks again! The new version was released to PyPI today. Also, I've added your name to the AUTHORS file.