search

tsssss / geopack

Python version of geopack and Tsyganenko models
MIT License
30 stars 12 forks source link

Field line trace #2

Closed w2naf closed 5 years ago

w2naf commented 5 years ago

Hi there.

I fixed a bug where the np.append results were not getting reassigned to a variable in geopack.trace(). Also, I found that maxloop=1000 is not always sufficient, so I made it a keyword. Finally, I created a notebook with a demo field line trace and visualization.

Thank you for your work on porting Tsyganenko to python.

Best, Nathaniel

tsssss commented 5 years ago

Hi Nathaniel,

Thank you so much for improving the package! I've merged the pull request.

Best wishes, Sheng

On Sun, 13 Jan 2019 at 15:19, Nathaniel Frissell notifications@github.com wrote:

Hi there.

I fixed a bug where the np.append results were not getting reassigned to a variable in geopack.trace() https://github.com/w2naf/geopack/blob/31c0e19cdc0cc6b1ebeedd7ca4509e46315a767a/geopack/geopack.py#L1193-L1195. Also, I found that maxloop=1000 is not always sufficient, so I made it a keyword https://github.com/w2naf/geopack/blob/31c0e19cdc0cc6b1ebeedd7ca4509e46315a767a/geopack/geopack.py#L1093. Finally, I created a notebook with a demo field line trace and visualization.

Thank you for your work on porting Tsyganenko to python.

Best, Nathaniel

You can view, comment on, or merge this pull request online at:

https://github.com/tsssss/geopack/pull/2 Commit Summary

  • notebook
  • changes to orginal nb
  • most recent
  • test
  • useless git commit message
  • Merge branch 'master' of https://github.com/tsssss/geopack
  • delete notebooks
  • assign append to variable and make maxloop keyword
  • Field Line Trace Notebook

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tsssss/geopack/pull/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AMLFhva0fTmXMhvlB0NAlooKz4YowMqKks5vC5TVgaJpZM4Z9Wsx .

w2naf commented 5 years ago

You're welcome. I'm glad to help!

Best, Nathaniel

On Sun, Jan 13, 2019, 8:17 PM Sheng Tian <notifications@github.com wrote:

Hi Nathaniel,

Thank you so much for improving the package! I've merged the pull request.

Best wishes, Sheng

On Sun, 13 Jan 2019 at 15:19, Nathaniel Frissell <notifications@github.com

wrote:

Hi there.

I fixed a bug where the np.append results were not getting reassigned to a variable in geopack.trace() < https://github.com/w2naf/geopack/blob/31c0e19cdc0cc6b1ebeedd7ca4509e46315a767a/geopack/geopack.py#L1193-L1195 . Also, I found that maxloop=1000 is not always sufficient, so I made it a keyword < https://github.com/w2naf/geopack/blob/31c0e19cdc0cc6b1ebeedd7ca4509e46315a767a/geopack/geopack.py#L1093 . Finally, I created a notebook with a demo field line trace and visualization.

Thank you for your work on porting Tsyganenko to python.

Best, Nathaniel

You can view, comment on, or merge this pull request online at:

https://github.com/tsssss/geopack/pull/2 Commit Summary

  • notebook
  • changes to orginal nb
  • most recent
  • test
  • useless git commit message
  • Merge branch 'master' of https://github.com/tsssss/geopack
  • delete notebooks
  • assign append to variable and make maxloop keyword
  • Field Line Trace Notebook

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tsssss/geopack/pull/2, or mute the thread < https://github.com/notifications/unsubscribe-auth/AMLFhva0fTmXMhvlB0NAlooKz4YowMqKks5vC5TVgaJpZM4Z9Wsx

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tsssss/geopack/pull/2#issuecomment-453883428, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvxDuAnx4VRy5hVvkJNwLkwFayzAomNks5vC9q3gaJpZM4Z9Wsx .