tst2005googlecode / re2

Automatically exported from code.google.com/p/re2
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

ParseInteger() is wrong #26

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. make static-test

What is the expected output? What do you see instead?

The expected output is that all tests pass. Instead, I see several compile and 
parse tests involving repetition (like "a{2}", "a{4}") failing.

What version of the product are you using? On what operating system?

$ hg identify 
8b066f89c3b5 tip

OS: linux-2.4 with gcc-3.3 on x86_64.

Please provide any additional information below.

The attached diff seems to fix the problem for me. I identified this decision 
as faulty while single-stepping obj/test/parse_test's first call to 
MaybeParseRepetition(). In that call, I saw incorrect behavior in ParseInteger 
on the "a{2}" test generate the incorrect parse that caused the test to fail.

Original issue reported on code.google.com by michael....@gmail.com on 28 Jul 2010 at 11:55

Attachments:

GoogleCodeExporter commented 9 years ago
Wow, how embarrassing.  Thanks for the fix.

Original comment by rsc@golang.org on 29 Jul 2010 at 1:15

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 5490d56a59.

Original comment by rsc@swtch.com on 4 Aug 2010 at 5:32