search

tst2005googlecode / umurmur

Automatically exported from code.google.com/p/umurmur
1 stars 0 forks source link

umurmur-0.2.7 does not compile on FreeBSD #26

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

I installed protobuf-c-0.15 and tried to configure umurmur

./configure --prefix=/usr/local/stow/umurmur-0.2.7 
CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib

What is the expected output? What do you see instead?

I expected configuration to complete, but it did not.
...
checking limits.h usability... yes
checking limits.h presence... yes
checking for limits.h... yes
checking malloc.h usability... no
checking malloc.h presence... no
checking for malloc.h... no
configure: error: missing a required header

config.log says

/usr/include/malloc.h:3:2: error: #error "<malloc.h> has been replaced by 
<stdlib.h>"

What version of the product are you using? On what operating system?

umurmur-0.2.7 FreeBSD 8.2

Please provide any additional information below.

I don't really know, but usage of malloc.h seems to be deprecated. In addition 
I didn't find any source file which includes malloc.h.

Original issue reported on code.google.com by todd...@gmail.com on 3 Jul 2011 at 8:02

GoogleCodeExporter commented 9 years ago 
Right. Fix is to remove 'malloc.h' from the list of header checks in 
configure.ac and run the autogen.sh script. That will regenerate the configure 
script. Requires that you have autotools installed.

Original comment by fatbob.s...@gmail.com on 3 Jul 2011 at 8:34

GoogleCodeExporter commented 9 years ago 
Thanks.

I Googled a bit. There doesn't seem to be agreement, should one use 'malloc.h' 
or 'stdlib.h'. However it is only small nuisance to remove the word from the 
file.

As a side note, use '= 'instead of '==' in configure.ac please. I mean

AS_IF([test "x$with_ssl" == xpolarssl], [ 
should be
AS_IF([test "x$with_ssl" = xpolarssl], [

AS_IF([test "x$with_ssl" == xopenssl], [
should be
AS_IF([test "x$with_ssl" = xopenssl], [

because the latter is much more portable, it works also with sh shell. The 
former (and the latter) works with bash shell.

Original comment by todd...@gmail.com on 4 Jul 2011 at 8:05

GoogleCodeExporter commented 9 years ago 
Fixed in commit 320a5588a8f195ee982722729c2b8dc99c68756f

Original comment by fatbob.s...@gmail.com on 7 Oct 2011 at 12:09