tst2005googlecode2 / lxmppd

Automatically exported from code.google.com/p/lxmppd
0 stars 0 forks source link

Provide muc#roomconfig_allowinvites in mod_muc plugin #254

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Use telepathy-gabble to connect to Prosody

gabble fails to create muc, see 
https://bugs.freedesktop.org/show_bug.cgi?id=37897 bug.

Actually, I'm not sure if it is a bug of Prosody or telepathy-gabble.

Any thought is it might be "fixed" on Prosody side

What is the expected output? What do you see instead?

Affected code is:

diff --git a/plugins/muc/muc.lib.lua b/plugins/muc/muc.lib.lua
index ff11bd6..7945005 100644
--- a/plugins/muc/muc.lib.lua
+++ b/plugins/muc/muc.lib.lua
@@ -608,6 +608,13 @@ function room_mt:get_form_layout()
                        type = 'boolean',
                        label = 'Make Room Members-Only?',
                        value = self:is_members_only()
+               },
+        -- Workaround for https://bugs.freedesktop.org/show_bug.cgi?id=37897
+               {
+                       name = 'muc#roomconfig_allowinvites',
+                       type = 'boolean',
+                       label = 'Whether to Allow Occupants to Invite Others?',
+                       value = false
                }
        });
 end

Original issue reported on code.google.com by alsro...@gmail.com on 18 Jul 2011 at 1:13

GoogleCodeExporter commented 9 years ago
This will need a bit more work. You have successfully added the option to the 
room configuration dialog, but the setting isn't actually used or saved :)

I'm changing the issue type from Defect to Enhancement. I'll see about making 
this work properly when I get a moment (unless someone beats me to it).

Original comment by waqas20 on 18 Jul 2011 at 11:24

GoogleCodeExporter commented 9 years ago
In fact, it is what telepathy-gabble is searching for, ie, after my "fix" I got 
telepathy-gabble working properly (properly means here that telepathy-gabble 
managed to start and do the rest of work, that does not relate to this feature, 
fine).

Is it possible to have some kind of stub in the way I did w/o implementing the 
whole feature (if I got it right) ?

Original comment by alsro...@gmail.com on 18 Jul 2011 at 11:35

GoogleCodeExporter commented 9 years ago

Original comment by waqas20 on 27 Jul 2012 at 7:49

GoogleCodeExporter commented 9 years ago
We're dropping this from 0.9 to prevent it blocking the (overdue) release.

Original comment by MWild1 on 26 Feb 2013 at 8:56