tstack / lnav

Log file navigator
http://lnav.org
BSD 2-Clause "Simplified" License
7.93k stars 315 forks source link

convert-to-local-time is undocumented #364

Open aspiers opened 7 years ago

aspiers commented 7 years ago

The tcsh_history format contains:

    "convert-to-local-time" : true,

but this is totally undocumented. It is the only format which contains that option. Looking through the git history, it seems that it was previously called local-time, and its implementation originally lived within the tcsh_history_format before being converted into a general option via 9b8ceb5cb0fd2e1. This comment seems pertinent:

        /*
         * NB: We convert any displayed dates to gm time, so we need to
         * convert this time to local and then back to gmt.
         */

but I don't yet understand what's going on.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/39380420-convert-to-local-time-is-undocumented?utm_campaign=plugin&utm_content=tracker%2F449456&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F449456&utm_medium=issues&utm_source=github).
aspiers commented 7 years ago

BTW if someone can explain this then I can try to document it correctly.