tstaerk / mediasyntax

Mediasyntax is a plugin for Dokuwiki that enables Mediawiki syntax.
http://www.staerk.de/thorsten/Mediasyntax
GNU General Public License v2.0
10 stars 6 forks source link

undefined constant then - problem and solution #25

Closed thecreator1970 closed 6 years ago

thecreator1970 commented 6 years ago

Hi,

I am using the mediasyntax-plugin of dokuwiki. It is a very usefull plugin for me.

There is an error in this mediasyntax-plugin. This results in the fault (on some web pages): Warning: Use of undefined constant then - assumed 'then' (this will throw an Error in a future version of PHP) in D:\xampp\htdocs\dokuwiki\lib\plugins\mediasyntax\syntax\codeblock.php on line 56

Solution is changing this file as follows:

56c56
<           if ($match[$i-1] == "\n" && $match[$i] == " ") then ;
---
>           if ($match[$i-1] == "\n" && $match[$i] == " ") {;}

Can this be changed in the new version please? Now I have to change it with each update.

Thank you, Bart

tstaerk commented 6 years ago

sounds good, but I am very busy. Do you want to become maintainer of mediasyntax?

tstaerk commented 6 years ago

fixed today

thecreator1970 commented 6 years ago

Thank you for the solution.

Op zo 26 aug. 2018 om 19:51 schreef Thorsten Staerk < notifications@github.com>

Closed #25 https://github.com/tstaerk/mediasyntax/issues/25.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tstaerk/mediasyntax/issues/25#event-1809440077, or mute the thread https://github.com/notifications/unsubscribe-auth/Am5vnbGOwW6Fdbu4QBxJFgf1udFQbcNzks5uUuAFgaJpZM4VApAY .

tstaerk commented 6 years ago

well it was your solution ;)

thecreator1970 commented 6 years ago

:-)

Op ma 27 aug. 2018 om 11:28 schreef Thorsten Staerk < notifications@github.com>:

well it was your solution ;)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tstaerk/mediasyntax/issues/25#issuecomment-416169800, or mute the thread https://github.com/notifications/unsubscribe-auth/Am5vnX-WsXpc2-AYDT2pWy-9WUMQc7FZks5uU7utgaJpZM4VApAY .