search

tsubasa853 / owasp-esapi-php

Automatically exported from code.google.com/p/owasp-esapi-php
Other
0 stars 0 forks source link

Rewrite filters/SafeRequest #44

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The first attempt of SafeRequest isn't very good and rather than address each 
of its defects individually, I believe a complete rewrite is in order.

One of the biggest problems is that the first call to any method which requires 
SERVER globals will cause the entire SERVER array contents to be canonicalised 
which is incredibly expensive and very rarely desirable.

Another issue is that SafeRequest tries to be two things at once: a filter for 
a request and a way to create a request (and used by unit tests) object.  
SafeRequest should probably stick to being a filter only - a way to access 
request related globals in a safe and consistent way.

Safe Request doesn't handle array type request parameters as it should.

Original issue reported on code.google.com by jahboite@gmail.com on 25 Jan 2011 at 1:48

GoogleCodeExporter commented 9 years ago

Original comment by jahboite@gmail.com on 25 Jan 2011 at 1:50

GoogleCodeExporter commented 9 years ago 
All these issues must be dealt with before 1.0. New issues will be on a case by 
case basis as to whether we hold up 1.0 or not.

Original comment by vande...@gmail.com on 17 Jun 2011 at 3:36