Log level conflict

[cfilkins]

https://github.com/tsugiproject/tsugi-php/blob/54d4477a25d97f7f4a5a6dbae28c1218faf8de05/include/setup.php#L83

On line 82, Tsugi is setting the logs to exclude notices, but on line 83 it counters that to include all. Are both of these here for a reason, or can one of them be commented out? Or should we look at adding a config setting to be able to control it there? Something like $CFG->showNotices = true/false?

[csev]

I don't think there is a logic to it - it might have been a test thing. My instinct is to keep it off.

/Chuck

On Jul 7, 2023, at 8:49 AM, cfilkins @.***> wrote:

https://github.com/tsugiproject/tsugi-php/blob/54d4477a25d97f7f4a5a6dbae28c1218faf8de05/include/setup.php#L83 https://github.com/tsugiproject/tsugi-php/blob/54d4477a25d97f7f4a5a6dbae28c1218faf8de05/include/setup.php#L83 On line 82, Tsugi is setting the logs to exclude notices, but on line 83 it counters that to include all. Are both of these here for a reason, or can one of them be commented out? Or should we look at adding a config setting to be able to control it there? Something like $CFG->showNotices = true/false?

— Reply to this email directly, view it on GitHub https://github.com/tsugiproject/tsugi-php/issues/36, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJEJJTJWBNXLUQ4WZ5N6QTXPAAUNANCNFSM6AAAAAA2BYX35M. You are receiving this because you are subscribed to this thread.

[cfilkins]

For the life of me, I can't get the notices to go away :( I've commented out all of them, and even left the first one to not include notices, and I'm still getting notices in the php logs. I've also tested making sure that my php.ini is set, and that I've removed it from nearly every other piece of code in the entire tsugi folder. Very strange :(

-Chris

On Fri, Jul 7, 2023 at 9:25 AM Charles Severance @.***> wrote:

I don't think there is a logic to it - it might have been a test thing. My instinct is to keep it off.

/Chuck

On Jul 7, 2023, at 8:49 AM, cfilkins @.***> wrote:

https://github.com/tsugiproject/tsugi-php/blob/54d4477a25d97f7f4a5a6dbae28c1218faf8de05/include/setup.php#L83 < https://github.com/tsugiproject/tsugi-php/blob/54d4477a25d97f7f4a5a6dbae28c1218faf8de05/include/setup.php#L83>

On line 82, Tsugi is setting the logs to exclude notices, but on line 83 it counters that to include all. Are both of these here for a reason, or can one of them be commented out? Or should we look at adding a config setting to be able to control it there? Something like $CFG->showNotices = true/false?

— Reply to this email directly, view it on GitHub < https://github.com/tsugiproject/tsugi-php/issues/36>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAJEJJTJWBNXLUQ4WZ5N6QTXPAAUNANCNFSM6AAAAAA2BYX35M>.

You are receiving this because you are subscribed to this thread.

— Reply to this email directly, view it on GitHub https://github.com/tsugiproject/tsugi-php/issues/36#issuecomment-1625413981, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWVUHDXDR4JHTQDG7O7CE3XPAE6DANCNFSM6AAAAAA2BYX35M . You are receiving this because you authored the thread.Message ID: @.***>