search

tsugiproject / tsugi

Tsugi Admin, Developer, and Management Console (pls join the dev list)
http://www.tsugi.org
Apache License 2.0
346 stars 257 forks source link

Missing Ellipses in store markup #160

Closed csev closed 1 year ago

csev commented 1 year ago

Hey @andrewniekamp - Sakai QA was doing some testing and noticed this:

When adding a tool, I see the following console errors: sakai.tsugicloud.org/:1064 GET https://sakai.tsugicloud.org/tsugi/lti/store/static/ftellipsis.js net::ERR_ABORTED 403

sakai.tsugicloud.org/:1149 

   Uncaught ReferenceError: Ellipsis is not defined
at [sakai.tsugicloud.org/:1149:24](http://sakai.tsugicloud.org/:1149:24)
at HTMLCollection.forEach (<anonymous>)
at [sakai.tsugicloud.org/:1148:13](http://sakai.tsugicloud.org/:1148:13)
andrewniekamp commented 1 year ago

Ah I see, it looks like I missed that library from the LTI store side. I see the Ellipsis js file is currently within tsugi at tsugi/store/static - does it sound alright to move that js file to tsugi-static and then reference it from there in both app stores?

csev commented 1 year ago

Yes - that would be the best strategy.