tsugiproject / tsugi

Tsugi Admin, Developer, and Management Console (pls join the dev list)
http://www.tsugi.org
Apache License 2.0
346 stars 257 forks source link

Fix two issues: #171

Closed zhuoY121 closed 1 year ago

zhuoY121 commented 1 year ago

There are two issues when updating php version to php 8.2.

  1. The creation of dynamic properties:

    • Error Message:
    • Deprecated: Creation of dynamic property Tsugi\Config\ConfigInfo::$slow_query is deprecated
    • Same error messages for $logout_return_url and $verifypeer
    • The solution is to add these fields to ConfigInfo.php
    • NOTE: I've included some basic comments while adding these fields in ConfigInfo. Feel free to enhance them further if needed.
  2. Passing null to strlen():

    • Error Message:
    • Deprecated: strlen(): Passing null to parameter # 1 ($string) of type string is deprecated
    • The solution is to use !empty() instead of strlen() > 0 in the if statement.
csev commented 1 year ago

This looks great! Thanks for the fix.