search

tsujan / BreezeEnhanced

A fork of KDE Breeze decoration with additional options
GNU General Public License v3.0
162 stars 13 forks source link

Top highlight not visible with dark colors #22

Closed ripefig closed 4 years ago

ripefig commented 4 years ago

image

tsujan commented 4 years ago

If the dark color is "#000", it shouldn't be visible because Qt can't make it lighter. Is it, in your case?

ripefig commented 4 years ago

Perhaps you can see it more clearly here: image I am talking about the faint light line at the top of titlebar. You can see it clearly on gray titlebars, but you can't see it at all if the titlebar is black.

tsujan commented 4 years ago

By using a color picker with your screenshot, I found that the color is really pitch black. QColor::lighter doesn't work with "#000". That's an old Qt issue. It has never been fixed; apparently, Qt devs don't see it as a bug!

BTW, pitch black isn't a good titlebar/window color because shadows won't be visible with it.