tsujan / BreezeEnhanced

A fork of KDE Breeze decoration with additional options
GNU General Public License v3.0
162 stars 13 forks source link

Make titlebar metrics configurable #32

Closed probonopd closed 3 years ago

probonopd commented 3 years ago

A common complaint about the upstream Breeze theme is that the title bars are too big and cannot be configured in a fine-grained way. I understand that BreezeEnhanced was made to make it more configurable, and I think it would be nice if titlebar metrics could also be made configurable via breezerc.

For example, I would like to achieve this result:

image

Especially, I would like to be able to set:

See breezedecoration.cpp and breeze.h in

https://github.com/helloSystem/BreezeEnhanced/commit/27a05ac4fb3b0e397acb468ae929b7167fe18791

for the type of changes I would like to see made configurable, so that one doesn't have to fork BreezeEnhanced just to make these kinds of configuration changes.

tsujan commented 3 years ago

Your feature request is quite valid.

But, as I said in https://github.com/tsujan/BreezeEnhanced/issues/31#issuecomment-822788786, I don't consider BreezeEnhanced as my program. It's rather the result of applying some patches of mine to Breeze, for using it with Kvantum. To me, it's 99% Breeze. What I do here is only updating it whenever needed. Having a limited amount of free time, which I spend on my own projects, I couldn't do that if it gets too different from Breeze.

So, I think the only way is forking. Sorry!

probonopd commented 3 years ago

Had you ever tried to get your improvements into upstream Breeze?

tsujan commented 3 years ago

Had you ever tried to get your improvements into upstream Breeze?

Years ago, I applied a simple patch to Breeze to make its ugly gradient smooth. I proposed that patch (I don't remember where) but they didn't accept it. Then I applied a few more patches to make it more beautiful and to change its title-bar font outside KDE. So, I'm sure they won't accept any of those patches.

probonopd commented 3 years ago

Would you happen to know how to disable the right-click menu that appears when one right-clicks on the window title? It contains a KDE Plasma specific menu entry that does not even work when the full KDE Plasma desktop is not installed.

tsujan commented 3 years ago

Would you happen to know how to disable the right-click menu that appears when one right-clicks on the window title?

Strange! Here, the title-bar doesn't have a right-click menu. I don't remember if there was a KDE option that I activated or they removed the menu — or even if that menu was there in the first place.

probonopd commented 3 years ago

I need to disable this entirely, since no KDE Plasma is installed on my system and some of the options in the menu need it.

image

tsujan commented 3 years ago

Here, the same menu appears on left clicking the window icon, not right clicking the title-bar:

menu

I don't know where its source is. I think it's quite useful.