search

tsujan / BreezeEnhanced

A fork of KDE Breeze decoration with additional options
GNU General Public License v3.0
162 stars 13 forks source link

Add outline to macos style buttons #38

Closed gurrgur closed 2 years ago

gurrgur commented 2 years ago

Hi, I really like this window decoration, especially with macos style buttons, but I noticed that compared to a real mac, the colored circles are missing an outline. This pull request adds a slight gray outline to the colored circles. The outline strength is loosely based on the appearance of macos Mojave.

Here, please take a look:

breeze_enhanced_light

The outline is made stronger when the titlebar background color is dark:

breeze_enhanced_dark

Here is another example using the color theme "Breeze Classic":

breeze_enhanced_classic

Edit: Note that I'm using LightlyShaders, which applies additional window corner rounding and adds an outline to the window.

tsujan commented 2 years ago

Thanks for your interest in BreezeEnhanced!

Making the buttons exactly like those of macOS wasn't my goal. As the code may show, the lack of outlines was intentional. At first, I added them without pushing a commit but soon didn't like them. Adding an option for them was an overkill.

Tastes differ, and that's the reason why KWin has several decorations. You could fork BreezeEnhanced and change it according to your taste (or even add more options to it). Sorry for closing your good PR!