search

tsujan / BreezeEnhanced

A fork of KDE Breeze decoration with additional options
GNU General Public License v3.0
162 stars 13 forks source link

Update breezebutton's public constructor #7

Closed trmdi closed 5 years ago

trmdi commented 5 years ago

Hi, From this: https://phabricator.kde.org/D16596 Could you please update breezebutton.cpp ?

tsujan commented 5 years ago

I should study the patch first; will do it soon -- maybe tomorrow. Thanks for telling me about it :)

tsujan commented 5 years ago

Found time and did it in https://github.com/tsujan/BreezeEnhanced/commit/159012b1afa32515b79ed419b9cd976e9e23303e

I don't use the property this patch is supposed to fix but it exactly reflects the upstream change. I hope it'll be useful to you.

Every time a new release of Breeze is published, I check its differences from the last one and make similar changes to BreezeEnhanced if relevant. However, if you want to have a feature sooner, please keep telling me about changes!

trmdi commented 5 years ago

Thank you @tsujan !

tsujan commented 5 years ago

You're welcome. Did it help?

trmdi commented 5 years ago

Sure. With that patch, we could bring BreezeEnhanced buttons with the hovering effect onto the Plasma panel. It's one main purpose of the patch. You could see a demo video here (but with your buttons like this). Your decoration effect is really nice. And your maintenance is very good too. Thanks again for those !