tsujan / Kvantum

A Linux SVG-based theme engine for Qt and KDE
1.56k stars 146 forks source link

Header hack detection if needed #236

Closed varlesh closed 6 years ago

varlesh commented 6 years ago

Borders on header widget sometime superimposed on window borders. Then we have two borders. It's not good looking if we want tiny (1 px) borders for all widgets. For example, on my theme Materia Blur i'm hack this manually, but not good way - i'm disable header-normal-top (make transparent or draw as window color without border): image If use normal border i'm have two borders - border window and header: image I know, it's not kvantum issue, but maybe this posible hacked? I mean if header widget not superimposed on window - kvantum fix that. Also this happened with left and right header borders.

varlesh commented 6 years ago

It's not critical for me, because mostly apps looking good...with disabled header-top border :)

tsujan commented 6 years ago

You want something like this:

header

Am I right? If so, it's already possible (the above screenshot is a modified Kvantum theme). You could try this:

[HeaderSection]
inherits=PanelButtonCommand
interior.element=header
frame.element=header
frame.top=0
frame.bottom=1
frame.left=1
frame.right=1
...

Then, make the elements header-normal-left and header-normal-right completely transparent in the SVG file and add the element header-separator if it doesn't exist. (There are other ways too)

There will be a minor drawback in list-views but it's tolerable.

Tonight (or tomorrow), I might edit KvCommunitheme to make it like the above screenshot.

Was the above explanation helpful?

varlesh commented 6 years ago

Yes, i know about frame.top=0 - it's similarly solution as use transparency or window color for header-normal-top. But i think it's application bug, because mostly popular apps good working. Qmmp draw strange widgets: image Thx for header-separator, it's very good solution))) Sorry for disturb you and thx for help. closed

tsujan commented 6 years ago

Oh, yes, that's a (small) problem in Qmmp and is visible with Fusion too:

qmmp

BTW, I found and fixed (worked around) some rare issues with translucent base colors. I'll make a commit tonight (or tomorrow) for them.

tsujan commented 6 years ago

Not related to this: IMHO, audacious-qt5 + audacious-plugins-qt5 is much better and cleaner than Qmmp. It's available on AUR (Arch git repository) -- I don't know about other distros.