search

tsukasaoishi / fresh_connection

FreshConnection provides access to one or more configured database replicas.
MIT License
58 stars 11 forks source link

Rename 'slave' to 'replica' everywhere #13

Closed aks closed 7 years ago

aks commented 7 years ago

Tsukasa-san,

I hope you do not mind this PR. Because of increased sensitivity to slavery in American history, there has been some suggestions, even in the technology world, to use other words, such as "replica", in order to avoid the social issues involved with the word "slave".

So, this PR is a change of the fresh_connection code base to use the word "replica", or "replica1", "replica2", etc. instead of "slave". The change has been made throughout the code base, everywhere.

I have confirmed that all tests still pass, for both MySQL and PG.

It includes some backward compatibility so that the new gem can continue working with the existing database configurations using the "slave" stanza. I have included a test to confirm this compatibility.

In addition, I also improved the content and English in the README. Even if you choose to not accept the "replica" change, there is a lot of good improvement in the README that you may wish to consider (perhaps I should have accomplished this in a separate PR).

Thanks for the useful software; I'm still evaluating it for use my company's application.

Thanks Alan

tsukasaoishi commented 7 years ago

@aks Thank you for the Pull Request. I respect and consent all your opinion. I will merge this PR after reviewing code. Please wait a while. Thank you to improve README!

aks commented 7 years ago

Tsukasa-san, the CI process is failing because of either DB existence (new names?) or access control (to the new DB names).

aks commented 7 years ago

Tsukasa-san, I replaced hard-coded user/pass on mysql DB config with envars, but using the same defaults as before this PR. This makes the test work for me, because I can set MYSQL_USER and MYSQL_PASS appropriately for my testing, but it should also work for CI because it will have the same defaults when those envars are not defined.

I reverted the version change.

tsukasaoishi commented 7 years ago

@aks Thank you for your contribution!