tsukasaoishi / fresh_connection

FreshConnection provides access to one or more configured database replicas.
MIT License
58 stars 11 forks source link

Implement DATABASE_REPLICA_URL, fix some tests & mispelling #15

Closed aks closed 7 years ago

aks commented 7 years ago

This PR adds support for an envar DATABASE_REPLICA_URL, which allows a user to completely specify all spec components from the URL. For example:

export DATABASE_REPLICA_URL='postgresql://dbuser:somepwd@databasehost:port/dbname?pools=10,prepared_statements=false'

Also:

tsukasaoishi commented 7 years ago

Thank you for your PullRequest. Sorry, I'm in a vacation. I'm going to come back next week. Please wait a while.

tsukasaoishi commented 7 years ago

I would be happy if you could write a README about specifying environment variables.

aks commented 7 years ago

Tsukasa-san, I've made your requested changes. Let me know if I missed something.

tsukasaoishi commented 7 years ago

Thank your for your contribution! If you dont's mind, could you squash all commits?

aks commented 7 years ago

Tsukasa-san, all commits squashed.