tsukasaoishi / fresh_connection

FreshConnection provides access to one or more configured database replicas.
MIT License
58 stars 11 forks source link

This adapter('redshift') is not supported. If you specified the mysql or postgres adapter, it's probably a bug in FreshConnection #38

Open untwal opened 3 years ago

untwal commented 3 years ago

rails: 5.1.7

fresh_connection is being reviewed by us, for the purpose of PostgreSQL read-replica usage in our project, currently, we are using activerecord5-redshift-adapter also in the project. While this activerecord5-redshift-adapter also use the ActiveRecord::ConnectionAdapters::ConnectionSpecification::Resolver following prepend is limiting us from using the same in our project. I am willing to make changes to the ArResolver Class.

Please let me know your thoughts on the same.

tsukasaoishi commented 3 years ago

Thank you for your pull request. I have no time to correspond all activerecord adapters. Your proposal is good idea. I commented your pull request. https://github.com/tsukasaoishi/fresh_connection/pull/39#discussion_r586408649