tsuna / gohbase

Pure-Go HBase client
Apache License 2.0
736 stars 213 forks source link

region: Add batch_flush_size histogram metric #223

Closed aaronbee closed 1 year ago

aaronbee commented 1 year ago

This will expose the size of batches being sent by gohbase.

Buckets are [1, 5, 25, 125, 625, 3125, 15625, 78125]. This should capture all expected sizes of batches and importantly count all the batches that have exactly 1 request in them. In one setup I saw 90% of batches containing exactly 1 request and in another the 99.9%tile value was ~3100 with spikes over 8000.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 :tada:

Comparison is base (6676fa3) 69.32% compared to head (4d8fd7a) 69.39%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #223 +/- ## ========================================== + Coverage 69.32% 69.39% +0.06% ========================================== Files 27 27 Lines 3583 3584 +1 ========================================== + Hits 2484 2487 +3 + Misses 985 983 -2 Partials 114 114 ``` | [Impacted Files](https://app.codecov.io/gh/tsuna/gohbase/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Sigoure) | Coverage Δ | | |---|---|---| | [region/client.go](https://app.codecov.io/gh/tsuna/gohbase/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Sigoure#diff-cmVnaW9uL2NsaWVudC5nbw==) | `82.77% <100.00%> (+0.45%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.