codecov-commenter
commented
1 year ago Codecov Report
Patch coverage: 53.12% and project coverage change: +0.03% :tada:
Comparison is base (
4bda353) 70.24% compared to head (288ab9b) 70.27%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #227 +/- ## ========================================== + Coverage 70.24% 70.27% +0.03% ========================================== Files 27 27 Lines 3714 3701 -13 ========================================== - Hits 2609 2601 -8 + Misses 988 986 -2 + Partials 117 114 -3 ``` | [Files Changed](https://app.codecov.io/gh/tsuna/gohbase/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Sigoure) | Coverage Δ | | |---|---|---| | [hrpc/call.go](https://app.codecov.io/gh/tsuna/gohbase/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Sigoure#diff-aHJwYy9jYWxsLmdv) | `70.00% <ø> (ø)` | | | [region/info.go](https://app.codecov.io/gh/tsuna/gohbase/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Sigoure#diff-cmVnaW9uL2luZm8uZ28=) | `66.66% <0.00%> (-0.60%)` | :arrow_down: | | [rpc.go](https://app.codecov.io/gh/tsuna/gohbase/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Sigoure#diff-cnBjLmdv) | `85.54% <36.84%> (+1.02%)` | :arrow_up: | | [admin\_client.go](https://app.codecov.io/gh/tsuna/gohbase/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Sigoure#diff-YWRtaW5fY2xpZW50Lmdv) | `53.57% <100.00%> (+1.21%)` | :arrow_up: | | [caches.go](https://app.codecov.io/gh/tsuna/gohbase/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Sigoure#diff-Y2FjaGVzLmdv) | `85.58% <100.00%> (-0.27%)` | :arrow_down: | | [client.go](https://app.codecov.io/gh/tsuna/gohbase/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Sigoure#diff-Y2xpZW50Lmdv) | `69.27% <100.00%> (+0.65%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/tsuna/gohbase/pull/227/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Sigoure):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
aaronbee
Documented RegionInfo type with information about those 3 states and the lifecycle.
Documented establishRegion with what it does and what it's requirements are.
Removed calls to SetClient(nil)/MarkUnavailable in clientRegionCache methods. That work is the responsibility of the caller.
getRegionAndClientForRPC no longer marks a region as unavailable if Client is nil after waiting on the AvailabilityChan. If Client is nil, that indicates the region is stale and a lookup has to be performed. Marking it as unavailable and trying to reestablish it is wasted effort.
The above change broke the use of the meta and admin regions, which are created when creating the gohbase Client/AdminClient, but don't have a Client set. These regions were relying on a missing Client to cause the region to be established. Now the meta and admin regions are established as part of NewClient and NewAdminClient, respectively.
closes: #186