tsuna / gohbase

Pure-Go HBase client
Apache License 2.0
737 stars 214 forks source link

Ensure region is made unavailable in clientDown #228

Closed aaronbee closed 1 year ago

aaronbee commented 1 year ago

The clients cache can get out of sync with what regions are actually associated with a region server. A case has been seen where region points to a region client that doesn't exist in the clients map. When this occurs subsequent calls to clientDown are no-ops, and the bad region continues to point to the incorrect region server.

clientDown will now ensure that the given region is made unavailable, even if it is not found in the clients list of regions.

closes: #186

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% :warning:

Comparison is base (4bda353) 70.24% compared to head (782a5bf) 70.24%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #228 +/- ## ========================================== - Coverage 70.24% 70.24% -0.01% ========================================== Files 27 27 Lines 3714 3720 +6 ========================================== + Hits 2609 2613 +4 - Misses 988 991 +3 + Partials 117 116 -1 ``` | [Files Changed](https://app.codecov.io/gh/tsuna/gohbase/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Sigoure) | Coverage Δ | | |---|---|---| | [rpc.go](https://app.codecov.io/gh/tsuna/gohbase/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Sigoure#diff-cnBjLmdv) | `84.66% <100.00%> (+0.15%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/tsuna/gohbase/pull/228/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Sigoure)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.