tsunamayo / Starship-EVO

Welcome to Starship EVO bug tracking repo !
114 stars 17 forks source link

[Bug] Invisible Collisions On Child Entities #2133

Open Tourist50 opened 4 years ago

Tourist50 commented 4 years ago

Short Description of the issue:

This seems to be a similar issue as something reported about two weeks ago; child entities seem to be clipping with bricks outside of the physical hitbox of the brick.

Original post about child entities colliding with bricks in strange ways: https://github.com/tsunamayo/Starship-EVO/issues/1960

Steps to reproduce the issue:

Load in my blueprints, then hit the switch behind the hinges to toggle the cockpit open and closed. When it closes, it should get stuck on the wedges in front where it looks like nothing is colliding. It's a little tempermental, so you may have to open and close it a few times until it doesn't close properly.

Environment

Additional information:

The first time I encountered this collision: image

Showing that it's these wedges at the front by removing them and having it work correctly: image

Collision points on: image

Recreating without cockpit blocks: image

Recreating on a different testbed with slightly different slopes: image

The two blueprints I've recreated this on:

Cockpit Clipping Blueprints.zip

Please also include the output_log.txt file. You can find your log here: %UserProfile%\AppData\LocalLow\Moonfire Entertainment\Starship EVO\

output_log.txt

tsunamayo commented 4 years ago

Just to confirm the issue: This is what you expect: image this is what you get sometime: image I just want to confirm that the first picture is the correct behavior for you, because this cockpit mechanism is never gonna retract more than that. Thanks

Tourist50 commented 4 years ago

Initially I expected the cockpit to close all the way as sometimes it would after freshly loading the craft or rebuilding the hinge system. However, after a few open and close attempts it would eventually get stuck on what seemed like thin air.

ItsCrusade commented 4 years ago

It looks like the bottom lip of the canopy is colliding with the bricks it's trying to move past - this makes sense, as when the canopy is moving - the bottom lip is lower than the hinges rotation point, so to complete the rotation past the bricks, it (the lip of the canopy) has to move slightly forward - colliding with the bricks instead.

Yes it will work sometimes, but this is due to the collision check not catching that very small collision on the frames it's calculating.

tsunamayo commented 4 years ago

Yes @ItsCrusade is correct, there is small threshold to not get stuck too easily, but this mechanism could not close in real life. It is still stopping too soon though, so there is an issue still. I keep you posted.

Majikmonster commented 4 years ago

I have a similar issue to this with my own canopy. Sometimes, when I close it, it doesn't close all the way. Trying to reset it results in the same stuck behavior for maybe a dozen, 2 dozen tries before it closes all the way again. However, if it closes all the way the first time, then it doesn't have the problem for a similar number of tries. 20200530223315_1 A successful closing: 20200530223302_1 An unsuccessful closing: 20200530223455_1 The ship blueprint: Majikmonster_ship_police_patrol_hot fuzz.zip game version: 20w22d output_log.txt