tsunamayo / Starship-EVO

Welcome to Starship EVO bug tracking repo !
117 stars 17 forks source link

[New build - EXPERIMENTAL] 20w28d: New Rendering Tech. #2655

Open tsunamayo opened 4 years ago

tsunamayo commented 4 years ago

First batch of hotfixes following the new rendering tech.

Changes:

Bugfixes:

tsunamayo commented 4 years ago

Build is up! Thanks all, tell me if you have any issue, once we get this cleaned I will release in DEFAULT... Cheers

alxnns1 commented 4 years ago

image image looks like its missing the patch notes and version number

BrickMacklin commented 4 years ago

Entire chunks are missing from my build whether I have culling on or off. Stickers are also not appearing. This is the same at any distance from the ship. Attached is a picture. image

Kaiser-Indrasil commented 4 years ago

Oh man, am I glad that you decided to delegate the new version to the experimental branch... there's so many bugs:

Also, this is what happens when I first get far from the ship with the Occlusion Culling enabled, then turned off, and then when I got close again: Starship_EVO_KEJFcdj7gS Starship_EVO_1A3CwRuN5h

ZachZent commented 4 years ago

The abstract art update

tsunamayo commented 4 years ago

@BrickMacklin could you send me your ship so I can investigate? You are seing no decals at all?

tsunamayo commented 4 years ago

@Kaiser-Indrasil Occlusion On / Off is not implemented as I cant skip the compute shader stage with the current implementation. Do you have a log file for the performance, there might be some error that could explain the drop. What is the name of your ship again? Thanks

tsunamayo commented 4 years ago

so Kaiser your ship is fine, it takes some FPS to display but I guess it was the same before. Occlusion Off is bugged (I havent worked on it), but thats a debug option. When you say 50% fps drop it is compared to what? Before the update?

tsunamayo commented 4 years ago

@BrickMacklin could you send me a log? I loaded your ship and it seems fine on my side, with the exception of the greedy unloading at a distance that I still need to fix (that was in previous update too). Decals were fine too... Thanks

Kaiser-Indrasil commented 4 years ago

Yeah, 50% drop compared to the main branch of the game 20w28b. Given a few minutes, it oscillates between 60 and 80 fps. I'n not sure if I've mentioned it yet but the loading time in the beta branch has at least doubled compared to the stable branch.

Oh, and here's the logs: output_log.txt

Are you able to reproduce the #2636 on your side?

tsunamayo commented 4 years ago

I havent looked at 2636

tsunamayo commented 4 years ago

where you using occlusion culling in old version?

tsunamayo commented 4 years ago

@Kaiser-Indrasil thats a log from the old version. For the loading time I will improve that a bit, right now it is not super optimum, but it still might be a bit slower that the old tech.

Kaiser-Indrasil commented 4 years ago

Damn, that is a valid point! With OC enabled, the fps in the Stable Branch oscillate between 80-100. Oh, so the log file wipes itself each time I start the game?

tsunamayo commented 4 years ago

yep it will. For the missing bit, was it with OC off? Occlusion Culling Off was bug. In your case as your ship is an empty shell and you have a big GPU I dont expect to see any gain with Occlusion Culling, that thats perfectly normal. It is not a tech that will improve your FPS all the time, it is a tech with a fixed cost that garantee your fps wont get smashed in a lot of use case (when there is a lot of overdrawn).

BrickMacklin commented 4 years ago

@tsunamayo Here you go! I did some more testing. The decals were appearing with culling turned on but then there's that usual bug of chunks disappearing. Paris Frigate.zip

tsunamayo commented 4 years ago

but there are disappearing at a distance right? Also did you tested all at Occlusion Culling On? Thanks

BrickMacklin commented 4 years ago

Let me make a video and get back to you

Kaiser-Indrasil commented 4 years ago

The one with the red circle I drew over? Nope, it was with OC on.

The other one when I first got away from the ship, then turn the OC off, and then got close again - it's a minor issue since the player won't really toggle the OC on and off constantly during gameplay.

tsunamayo commented 4 years ago

I fixed the distance bug btw.

BrickMacklin commented 4 years ago

@tsunamayo here is a video I made only a few minutes ago showing the effects on the ship. It is still processing so it might not show right away. https://youtu.be/6BwVzwvDtSM

tsunamayo commented 4 years ago

Like I said Occlusion Culling Off is not working, dont use it. Distance bug is fixed. But it seems that when you ticked freeze occlusion culling there was none applied. Could you send me a screenshot of your ship, with F3/Rendering/Show Hi-Z Buffer ?

BrickMacklin commented 4 years ago

image

If I move back this happens. This is on the game default loaded settings. image

And with culling turned off. image

tsunamayo commented 4 years ago

also I would really like to know if some guy with AMD card tested that build! Thanks all!

Kaiser-Indrasil commented 4 years ago

ProPeach has one (weird that I can't tag them here...)

ProPeach commented 4 years ago

I'll give it a try after lunch! Is there anything specific you want tested, or just how ships look in the new branch?

tsunamayo commented 4 years ago

yeah if it works at all, AMD has been giving me a lot of headaches in the past...

ProPeach commented 4 years ago

I'm running an RX 580 8GB Stable Branch OC on - 40ish FPS of a ship heavy scene, although many don't have interiors but there are a lot of bricks on show image With Occlusion culling frozen, you can see not much is actually removed Some of the base on the ground wasn't on the screen so it's not rendered, but none of the far side of the ships in the foreground were un-rendered even though they were not visible. image

Lots of ships had chunks missing thanks to to LOD tech though

Experimental OC on - 50-60 FPS stable, all the stickers etc on ships appear fine. I can't see anything wrong with it! image With Occlusion Culling frozen, we can see entities that were out of the players line of sight were culled (notice the ground base and the grey transport with no nose), but again the far side of ships were not culled. image

Still lots of chunks missing from the LOD, the render distance for this seems really low.

By disabling OC I can get 5-10 FPS more in this particular scene.

I'm happy to test anything else that needs it o/

tsunamayo commented 4 years ago

Okay great thanks for testing @ProPeach , at least thats that!