tsunamayo / Starship-EVO

Welcome to Starship EVO bug tracking repo !
112 stars 17 forks source link

[BUG] Docking connector and child entities don't transfer fuel. #5736

Open SovietSponge opened 2 months ago

SovietSponge commented 2 months ago

Short Description of the issue:

Child entities and docking connectors don't transfer fuel or items like they should.

Steps to reproduce the issue:

Connect two ships with docking connectors, link the docking connectors to their respective ship's fuel systems. Attempt to run a fuel line through a child entity.

Environment

Additional information:

image This doesn't transfer fuel to the smaller ship

Player.log

mobile base.zip shittle.zip Here are the two ships I've been trying this out with in survival. The mobile base has an extendable fuel scoop system with which I've had to rely on hoses as I can't seem to pipe water through the piston.

tsunamayo commented 2 months ago

Hi, I am not sure what you expect is coded to the game: what will happen for now is that the reactor will try to request some fuel from a connected tank, which might be from the docked entity. I guess what you would expect is some kind of a auto-refill: once docked the tank from the docked entity will try to refill from parent one. This would require at least a setting at the level of the docked port, as sometime you might want to refill and sometime dump fuel.

Am I correct?

SovietSponge commented 2 months ago

Ah so that's how it's meant to be. Yeah seems I mislabeled that part of it as a bug and a setting for it would be excellent. The child entity part of the report still seems to be an issue though.