tsunamayo / Starship-EVO

Welcome to Starship EVO bug tracking repo !
112 stars 17 forks source link

[Suggestion(Maybe?)] Potential fix to the CE Disappearing "glitch" #5825

Closed Timtee closed 1 week ago

Timtee commented 1 week ago

I make this issue as of today mostly cause I may have hit a bit of a brainwave moment in regards to what may be causing the issue with child entities disappearing upon world load(especially when there are a bunch of them present.)

My thought is that, it's not anything to do with blueprints persay, but rather, how the game handles loading in ships upon world load, which is to say, If the game tries to load all child entities present all at once upon world load, that then such may be the source of the fault. A way to fix this would be to individually load each child entity at a time, which.... could take a bit longer to do, but depending on the speed of the physical drive the game is installed and running on, would affect how long that takes.

Additionally is a suggestion for protection against child entities disappearing from both a ship in a world, and in a saved blueprint by the same name or entity uid or whatever. Which is - If the blueprint is older than said version of the ship in the world, then the blueprint should have an automatic protection against the child entity or entities, being removed off of it by the game. Thus saving many hours of work for many people. This would also have to ensure that if a given copy of the ship is older than the blueprint, that a check has to be put in place to compare the blueprint and ship, to ensure that it isn't just a corruption on one version and not both or otherwise.

The primary reason why I even have typed all of this out, is because... I'd love to make a unique ship idea I got today in Sevo but... due to the CE disappearing issue, I can't exactly risk it with the size of the ship, Besides, if you can figure out how to implement/fix all of this Tsuna, then all of us, every single player who has had to deal with the issue, or fears having to deal with it, will be grateful for your work to fix it once and for all.

Also relative to the original report on the issue since well... yeah. https://github.com/tsunamayo/Starship-EVO/issues/5695

ProPeach commented 1 week ago

Could the issues covered in #5695 be caused by the fix for #5436? That talks about deleting child entities if they showed that corruption bug, which could explain why so many builders are getting disappearing CEs recently and losing progress

Timtee commented 1 week ago

It might be yeah, that might be part of what is causing it too, is that it's not... really a good solution. Since it more often than not, just randomly will yeet a given child entity upon world load anyways. That and since Unity is Unity... Anything that such a thing would see as a potential corrupted bit, it will yeet. Even stuff that isn't actually corrupted.

Which actually an edit here but... A thought just occurred, What if the combination of that "fix" and what I said, aka game being overwhelmed on world load with child entities if there are a bunch, is actually resulting in accidental "corruption" in the sense of loss of particular data specific to a given child entity such as... it's unique ID that each entity has, which would explain the CE disappearing issue's cause in two parts, an attempted fix at corruption that can occur with them on rare occasion, and the game getting overwhelmed by allot of child entities, Which at that rate... Is a "fix" for a bug really a fix anymore if it inadvertently caused another larger bug? (which then again, this kind of thing is a coder/developer's worst nightmare anyways haha.)

Either way what needs to happen if such is the case, and even if it isn't, is that the game needs a protection method that doesn't delete child entities, but tries to repair them and regenerate any potentially bad data so that the ship's CEs don't get completely yeeted or yeeted at all at that point.

tsunamayo commented 1 week ago

@ProPeach Hi, so there has been a lot more CE deleted recently?

ProPeach commented 1 week ago

@tsunamayo it's affected quite a few builders as you can see in the replies to #5695 yeah. It still seems relatively rare, it's only happened to me once as far as I know but as you can imagine it is very disheartening to people to have the potential to lose a big chunk of their build, so people are hearing about it and getting concerned

asanagisae commented 1 week ago

I've lost parts from 2 ships in the last 2 weeks, one in a mech preview world and one in a default branch world. They were parts of medium complexity with more attached entities.

Recently, we've had high profile players just give up and stop playing (like Coconut) because of this bug.

tsunamayo commented 1 week ago

I've lost parts from 2 ships in the last 2 weeks, one in a mech preview world and one in a default branch world. They were parts of medium complexity with more attached entities.

Recently, we've had high profile players just give up and stop playing (like Coconut) because of this bug.

Okay dont hesitate to bring that kind of info to me when there is a serious bug. I was not aware that was a regression. It is fixed for 24w26a. Cheers