tsunamayo / Starship-EVO

Welcome to Starship EVO bug tracking repo !
112 stars 17 forks source link

[New build - DEFAULT] 24w27a: Sadde and pedestal, mech improvements #5848

Open tsunamayo opened 5 days ago

tsunamayo commented 5 days ago

This build features several improvements for mech following tester feedback.

A new saddle and pedestal seat have been added.

Mech improvements and fixes:

Kaiser-Indrasil commented 5 days ago

Quick bug report before everyone wakes up @tsunamayo Standing Seat is missing from the game image

Kaiser-Indrasil commented 5 days ago

I'm not sure what's the point of the Saddle to be honest - we already have regular chairs which provide the exact same seating pose.

image

Sure, it doesn't stick out from the back like the seats do, but the main application point would be bikes. But on a bike, you sit at a 45 degree angle forward with your legs spread apart, like this:

image

Sure, we could already use Ottomans on a hinge to make a similar effect, but then the player's camera and the character's face are facing downwards:

image

Now, Standing Seat makes sense because it is small AND provides a new "seating" pose Saddle could use one too

image

tsunamayo commented 5 days ago

Well I am waiting for more people to chime in, if people agree I could try to tweak the pose. For now it is an easy rider one...

Tackietacktack commented 5 days ago

Yeah, 45°degree are good for a racing bike but by Harley, horses or so its too much. Spreaded legs were pretty so that we get a 50cm brick between? Don't see it in game.

ProPeach commented 5 days ago

Thank you for adding the seats! It's great to see them again

I think it would be cool to have a slight angle forward. Interestingly if you setup a yoke, the idle animatoin actually leans the character forward a little bit temporarily which does look nice.

https://github.com/tsunamayo/Starship-EVO/assets/27857711/d1ef57b6-e93f-4f73-ad45-2e9cad9478c0

image

Would it be posible to link the amount of bend at the characters waist to how far away the yoke is? That would mean you could have an upright pose or an angled pose for the same seat

One thing that I do think would improve all the poses on the seats is moving the character back by ~15cm, so that they actually sit with their back against the seat. There is a lot of dead/empty space with the current poses. image

image

Crimson-Artist commented 5 days ago

I think the current saddle seat should have more open legs like you are actually straddling it. I also think there should also be a another version of the saddle seat that is turned 90 degrees and keeps the current sitting animation.

Also I found a bug. Standing seats that are linked to a yoke will cause the character model to teleport and clip into the parent entity as opposed to teleporting to the standing spot.

Tackietacktack commented 5 days ago

I don't know if it is a alternate but if it is possible to combinate seat and pedestal seat, which make possible to change the leg degree. Like pedals.

If it is be possible we need definitiv One foot Pedals!! And speed value from a event gate!! 🙏😬Gas pedal, That would be dream. By joysticks it is the same we can control two left and right.

Crimson-Artist commented 5 days ago

I think there should be an easier way to enter standing seats. Right now they are so small and subtle that people might not notice it as the thing we have to interact with. So I was thinking that adding some kind of logic component where if you connect a logic input like a button a standing seat pressing the button while standing about 1/2m from the seat will teleport the player into the seat. This will make it easier for certain builds like tight exo suits that only open from the top.

ZachZent commented 5 days ago

Actual saddle has you straddling the seat, not sitting in it. image

BigBadKangaroo commented 5 days ago

Hi there, I have to agree with the seating animation of the new saddle is a bit weird and doesn't really fit it's style / use purpose.

I made two sketches of what I would expect from the saddle: Chopper_pos_back Chopper_pos_side

In these skecthes the player model sits a bit further back in the seat, leans forward and has angled legs to create a more realistic pose. The legs spread so a 1/4th brick fits easily between the legs (maybe even a bit more?). The arms grab the handles and reach forward to do so. (Small thing to notice; the player grabs the handles "inverted". Normaly while riding a bike for example, the fingers point downwards and not upwards like they're now. Possible chance for a "bike style" yoke?

Something that bothers me is that the character doesn't lean forward to grab the handles if it doesn't reach while sitting normally. I had to place the handles 1/8th brick closer to even reach it: 20240702195726_1

Here's the BP in case you want to get a look at it. It's just a basic concept: Chopper.zip

I tested the standing seat aswell, works great and gives me ideas for locking players in position for open spaces on hovercrafts or spaceships, i.e. troop carriers where the troops stand in the loading bay (Republic gunship from Star Wars etc) I can imagine that some players might find it difficult to recognize this seat, if they didn't build the ship themselves and didn't know where to find it. However, I don't really have an idea on how to "improve" that without breaking it's usefulnes. It's a great seat and does what I expected from it.

In general I really like these 2 new seats. One of them just needs a more polished seating animation :)

tsunamayo commented 5 days ago

@ZachZent Sorry I forgot to update you, I had repushed the build with the fix for standing.

tsunamayo commented 5 days ago

In next update:

image

tsunamayo commented 5 days ago

@ProPeach problem is that updating this would break all current ship design...

ZachZent commented 4 days ago

@tsunamayo Can still make a new chair and keep the old chair, but hide it in the codex

ProPeach commented 4 days ago

@tsunamayo would it just move the player back in existing seats, or actually break things so that those seats no longer work?

If it just moves the player position in old builds, I would be absolutely fine with that! There have been a few issues raised on Github over the years about moving the seat position back so I think you'll have popular support if you do

SovietSponge commented 4 days ago

Personally would like seeing seats changed, at worst the characters would sit a bit far back in my fake seat cushions and it'd be far easier to build compact tiny builds if you didn't have to account for about 25cm of space extra simply due to the odd seating positions of current seats.