search

tsunamayo / Starship-EVO

Welcome to Starship EVO bug tracking repo !
117 stars 17 forks source link

[Bug] 24w27b- Ship/Entity gravity well only applies to another entity once it has collided with it #5862

Open Crimson-Artist opened 3 months ago

Crimson-Artist commented 3 months ago

A strange gravity based bug that ive found. The gravity well of an entity, despite being on, will only effect another entity when the first entity has physically collided with it. Gravity works fine on the player so this bug seems to deal with entity to entity physics. I have a video to show it in action.

In the video I have a ship that has a gravity unit forcing gravity upwards. I have artificially extend the ship's entity bounds so it will cover a large space underneath the ship. Gravity only seems to apply to the various other entities I'm flying over when my ship hits them.

https://github.com/tsunamayo/Starship-EVO/assets/112352428/38314745-1c52-4194-9111-7d69a8e2ecb0

ProPeach commented 3 months ago

I might be misremembering, but I think there's a limitation where gravity field cannot actually apply any force outside the ships own bounds, even if the gravity field extends outside it. So it might not be the collision which is triggering the gravity effect, but the fact that the ship basically has to collide with the other one to get it within its bounds.

Crimson-Artist commented 3 months ago

I might be misremembering, but I think there's a limitation where gravity field cannot actually apply any force outside the ships own bounds, even if the gravity field extends outside it. So it might not be the collision which is triggering the gravity effect, but the fact that the ship basically has to collide with the other one to get it within its bounds.

The gravity field of this ship extends well beyond the its entity bounds It should be working. At 0:13 you can see the mech start to float upwards when when I didnt hit it so there might be a problem with the physics engine applying gravity.

Crimson-Artist commented 3 months ago

Managed to capture a better video of it https://github.com/tsunamayo/Starship-EVO/assets/112352428/5ce88790-2a23-44e5-9a6e-d3c973cb0b49

ProPeach commented 3 months ago

Ah yes that shows it well, the collision really is "waking the ship up" to the effects of gravity lol. A similar issue got fixed recently where freshly undocked ships ignored gravity until a block update, hopefully the fix for this one is similar too