search

tsunamods-codes / 7th-Heaven

The Ultimate Mod Manager for Final Fantasy VII PC
https://7thheaven.rocks/
Microsoft Public License
129 stars 26 forks source link

Installer for 3.9 need Admin to run. #208

Closed barkermn01 closed 3 months ago

barkermn01 commented 5 months ago

Describe the bug The installer for 3.9 installing .Net 7/8 stuff all requires admin when running the 7th heaven installer they are all prompting for admin the installer should just be running as admin so all the other installers can just run without asking the user 4 separate times for UAC permission.

Versions [ ] Tested on latest stable version [ X ] Pre-release only bug

julianxhokaxhiu commented 5 months ago

Hey Martin, thanks for rising this issue but I'm afraid it won't be the case. The installer is set to run as non-admin on purpose because the app itself doesn't require Admin permissions, only on specific cases ( and practically none for the upcoming 4.0 stable where native Steam support will be present ).

Dependencies are fine to ask for admin permissions as there's no way to install them without and chances are you might have them installed already, if not, we're just doing a "kind gesture" to download and install them if they are missing so it's normal admin permissions are required.

Because of this, our installer will never ask for admin permissions, unless we can do that only for dependencies before installing them. Any idea here is appreciated, but having the user asked for admin permissions when we install in non-admin paths by default will result in a confusing behavior.

barkermn01 commented 5 months ago

The operation of an app is separate from its installation, yet this distinction often leads to complications for many users.

For instance, in my case, the software installs on the C drive by default since it's user-run without administrative privileges. As the owner of the computer, I should have the authority to choose the installation directory. It's unreasonable for the software to occupy my boot drive when I have a 2.8 TB drive available. Consequently, I've decided to avoid software that doesn't allow me to select the installation path, including Fusion 360, which consumed 120 GB (when i had to purge it) in my user directory, filling up my boot drive. as more software does this all your doing is forcing people to have to run on newer hardware because they have to be running a GPT system with much more expensive boot drives because soon there primary drive will have to be multiple terabytes big so either bios raid (unstable as hell) or very expensive drives, or very expensive Raid cards in there system.

Perhaps a better solution would be to offer two types of installers: one for advanced installation that runs with administrative rights, and another for standard installation.

julianxhokaxhiu commented 5 months ago

Sorry, maybe I'm not following you but the 7th installer today allows you to pick the path you want, you're not forced to install it on the default path. Am I misunderstanding something? Maybe send some screenshots so I can better understand what you mean, thank you.

barkermn01 commented 4 months ago

image image

Thoes are the only screens i get before installing from the installer there is no path choice screen.

julianxhokaxhiu commented 4 months ago

That is because InnoSetup has a functionality to detect existing installations, and if that's the case it will skip the path selection.

Try to uninstall it and run the installer again, this should appear as the first screen image

julianxhokaxhiu commented 3 months ago

Closing as inactive. Feel free to come back in case you find any issue. Cheers!