tsunamods-codes / 7th-Heaven

The Ultimate Mod Manager for Final Fantasy VII PC
https://7thheaven.rocks/
Microsoft Public License
129 stars 26 forks source link

Error when launching a non-english version (checking genuine FF7 version failing) #211

Closed ShadCanard closed 3 months ago

ShadCanard commented 3 months ago

Describe the bug A clear and concise description of what the bug is.

Versions [ ] Tested on latest stable version [ ] Pre-release only bug [X] Tested on Canary and Source code (via Visual Studio)

To Reproduce Steps to reproduce the behavior:

  1. Open 7th Heaven
  2. Configure 7th Heaven to open FF7_fr.exe or FF7.exe
  3. Launch the game

Expected behavior Games starts launching

Screenshots During the search for pirated game, the checksum is calculated on a

(GameConverter.cs line 146) : using (FileStream fs = new FileStream(Path.Combine(InstallPath, "ff7_en.exe"), FileMode.Open))

Games that aren't from US uses a culture name (for example ff7_fr.exe for a french user). Sooo... checking on ff7en returns an error as the file doesn't exists. This would work better if the check was made on Sys.Settings.FF7Exe meaning that the version of FF7(CurrentCulture).exe would be made on the correct filename.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

julianxhokaxhiu commented 3 months ago

7th Heaven does not support any non-English language. That is on purpose, because 99% of the mods are being built with the English exe in mind. To simplify the support process in either case, be it on ours or on modders, we decided to support only the English edition of the game.

If you look to play the game in any other language, we suggest you to have a look at SYW which is the alternative solution which supports French, German and Italian languages.

Cheers!