tsunamods-codes / 7th-Heaven

The Ultimate Mod Manager for Final Fantasy VII PC
https://7thheaven.rocks/
Microsoft Public License
129 stars 26 forks source link

iss: Fix Proton compatibility #215

Closed dotaxis closed 2 months ago

dotaxis commented 2 months ago

This should address https://github.com/tsunamods-codes/7th-Heaven/issues/206 / https://github.com/tsunamods-codes/7th-Heaven/discussions/207

Issue also tracked downstream: https://github.com/dotaxis/7thDeck/issues/39

I'm not sure why, but when trying to use the canary installer on Linux, {userpf} is causing the Inno setup to fail and throw the following error:

Internal error: Failed to expand shell folder constant "userpf"

image

According to the Inno documentation, {userpf} will default to {localappdata}\Programs on older versions of Windows, and in my testing I found that to also be the case on Windows 10 22H2.

This PR switches out the use of {userpf} for {localappdata}\Programs which should functionally be the same, but does not fail to install on Linux with Proton 9.

julianxhokaxhiu commented 2 months ago

Thanks a lot!