tsungtingdu / heymd

0 stars 0 forks source link

Refactoring #11

Open pjchender opened 3 years ago

pjchender commented 3 years ago

https://github.com/tsungtingdu/heymd/blob/1395533d9abe7073c3b33c1d7dd5c5f49bef76a0/src/components/Navbar.js#L294

可以試試看這種寫法:

// 原本
  const handleUserDelete = (e, email) => {
    e.stopPropagation();
    e.preventDefault();
    dispatch({
      type: "REMOVE_COLLABORATOR_REQUEST",
      payload: {
        email,
        postId: roomId ? roomId : null,
      },
    });
  };

// 後來
const handleUserDelete = email => e  => {
    e.stopPropagation();
    e.preventDefault();
    dispatch({
      type: "REMOVE_COLLABORATOR_REQUEST",
      payload: {
        email,
        postId: roomId ? roomId : null,
      },
    });
}

使用的時候會變這樣:

// 原本
<i
  className="far fa-trash-alt deleteIcon"
  onClick={(e) => {
    handleUserDelete(e, i.userEmail);
  }}
/>

// 後來
<i
  className="far fa-trash-alt deleteIcon"
  onClick={handleUserDelete(i.userEmail)}
/>

同時附上 commits 中的 comments

pjchender commented 3 years ago

Auto check this commits(3654437cfa6)