Closed otherpirate closed 2 years ago
@tcarreira could you please review it?
Great description @tcarreira, thank you 👏
I hope now we are ready to go
If there is other concerns, please let me know
Giving up, thx @tcarreira
nooo, don't give up @otherpirate 😉 If you activate the "Allow edits by maintainers" I could help you finish it.
Of course, if you still want to give up, it's up to you.
Hey @otherpirate After the merge of #191, this PR can be implemented. Do you want to give it a last try?
what should be done:
func installPlugin(pluginName, pluginURL string) error
http.Get(pluginURL)
(actually, until defer resp.Body.Close()
referring to that line)PluginManifest
. If it fails, keep the old behaviorPluginManifest.UrlPerPlatform[GOOS/GOARCH]
installPlugin()
with this new pluginURLTo prevent infinite recursion, the func installPlugin(...)
could take an extra argument: a counter to be checked for recursion
Let me know either decision ;)
Add support to multi platform pluging install
Check list
Closes #172