tsuru / tsuru-client

tsuru-client is a tsuru command line tool for application developers.
https://docs.tsuru.io/stable/
BSD 3-Clause "New" or "Revised" License
95 stars 77 forks source link

Add handle to multi platform plugin install #189

Closed otherpirate closed 2 years ago

otherpirate commented 2 years ago

Add support to multi platform pluging install

Check list

Closes #172

otherpirate commented 2 years ago

@tcarreira could you please review it?

otherpirate commented 2 years ago

Great description @tcarreira, thank you 👏

I hope now we are ready to go

If there is other concerns, please let me know

otherpirate commented 2 years ago

Giving up, thx @tcarreira

tcarreira commented 2 years ago

nooo, don't give up @otherpirate 😉 If you activate the "Allow edits by maintainers" I could help you finish it.

2022-10-10_10-14

Of course, if you still want to give up, it's up to you.

tcarreira commented 2 years ago

Hey @otherpirate After the merge of #191, this PR can be implemented. Do you want to give it a last try?

what should be done:

To prevent infinite recursion, the func installPlugin(...) could take an extra argument: a counter to be checked for recursion

Let me know either decision ;)