tsurumeso / vocal-remover

Vocal Remover using Deep Neural Networks
MIT License
1.47k stars 215 forks source link

Updated librosa function calls that do not comply to PEP3102 #125

Closed dependanz closed 1 year ago

dependanz commented 1 year ago

tl; dr

I updated librosa.load, librosa.stft, and librosa.istft to specify keywords after the first positional argument (because librosa >= 0.9 complies with PEP3102)

Summary

In reference to #123 and #124, that get the error load() takes 1 positional argument but 3 positional arguments (and 2 keyword-only arguments) were given

If you use the tool on Google Colab 2023 (where pip freeze displays librosa==0.10.0.post2), librosa>=0.9 updated their function calls to comply with PEP3102, where anything past an asterisk is "keyword-only."