tsuyoshicho / action-mypy

Run mypy with reviewdog on pull requests to improve code writing experience.
Creative Commons Zero v1.0 Universal
20 stars 8 forks source link

"Running mypy with reviewdog 🐶 ..." does not comment and shows no error, despite errors. #115

Closed bernhardkaindl closed 9 months ago

bernhardkaindl commented 9 months ago

I run into the same issue as the 2nd issue reported in #111:

Second, the step "Running mypy with reviewdog 🐶 ..." shows no output and passes without errors, even when there are typing errors in the project:

I enabled mypy --verbose and see that mypy is issuing two warnings for a file (it mentions two times that it has a warning about a place in the file), in the step "Running mypy with reviewdog 🐶 ...", but the action hides the actual errors and does not add a comment to the PR.

bernhardkaindl commented 9 months ago

Example PR: #https://github.com/xenserver-next/xen-api/pull/6

In this PR, there are some comments but they are incomplete:

🚫 [mypy] reported by reviewdog 🐶 Function is

Also, the file from which I get errors has more errors that are not added as comments.

Workflow output: https://github.com/xenserver-next/xen-api/actions/runs/7688914348/job/20950684779?pr=6

I am still trying to diagnose it.

I also have scripts that parse the output of pytype, pylint and pyre and output GitHub annotation messages. Maybe one can be updated for mypy. It could help with converting the output into a format that reviewdog can digest better (also with respect to multiple line errors).

tsuyoshicho commented 9 months ago

Hi @bernhardkaindl

Thank you

Wait a little longer

tsuyoshicho commented 9 months ago

Hi @bernhardkaindl

https://github.com/xenserver-next/xen-api/actions/runs/7688914348/job/20950684779?pr=6 https://github.com/tsuyoshicho/action-mypy/issues/38 mypy may return multi-line results. Cannot be improved until a solution is created, such as being able to get results in JSON!

This can be mitigated somewhat with ignore_note.

Your PR is helpful, I will examine it and merge it.

tsuyoshicho commented 9 months ago

Hi @bernhardkaindl

I have released v4.0.1. Please try to understand and use the above support.

https://github.com/tsuyoshicho/action-mypy/releases/tag/v4.0.1

This issue is closed.