tsuyoyo / sugorokuon-project

ラジコンシェルジュのコードです
0 stars 0 forks source link

ContainerHolderSingletonを触るところでNPE #6

Open tsuyoyo opened 8 years ago

tsuyoyo commented 8 years ago

ContainerHolderSingleton.getContainerHolder()がNullになりうるのに、ほかのチェックをすり抜けてる

private int fetchSetlistAfterByHour() {
        int fetchPeriod = DEFAULT_FETCH_PERIOD_HOUR;
        ContainerHolder holder = ContainerHolderSingleton.getContainerHolder();
        if (null != holder) {
            Container container = holder.getContainer();
            String containerKey = getString(R.string.gtm_key_interval_song_update_by_hour);
            fetchPeriod = (int) container.getLong(containerKey);
        }
        return (0 < fetchPeriod) ? fetchPeriod : DEFAULT_FETCH_PERIOD_HOUR;
    }