tsuzu / xld

Automatically exported from code.google.com/p/xld
0 stars 0 forks source link

cover art from freedb doesn't get embedded into m4a files transcoded from FLAC unless it was already embedded in the FLAC file #179

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. extract a CD to FLAC (single image) without setting metadata tags
2. transcode to m4a (individual tracks) with metadata (including cover art) 
fetched from freedb/musicbrainz

How about the reproducibility (always, sometimes, rarely, ...)?
always

What is the expected output? What do you see instead?
the m4a tracks should each contain the fetched cover art.  instead they contain 
no image.  (but if you had instead fetched the cover art and added tags to the 
FLAC file when you first extracted it from the cd, and then created m4a from 
that FLAC file, then they would each contain the cover art as expected).

What version of the product are you using? On what operating system?
20130407.  Mac OS: snow leopard (10.6.8)

Please provide any additional information below.

Original issue reported on code.google.com by maspo...@gmail.com on 28 May 2013 at 8:22

GoogleCodeExporter commented 9 years ago
In other words, it appears that when going from FLAC -> m4a, cover art is only 
transferred if it was already embedded in the FLAC file: if the FLAC file 
contained no image, then no image is embedded into the m4a tracks, even if 
cover art has been successfully fetched from freedb or musicbrainz prior to 
transcoding.

Original comment by maspo...@gmail.com on 28 May 2013 at 8:24

GoogleCodeExporter commented 9 years ago
Cannot confirm. Cover art is properly embedded to m4a (do you mean ALAC or 
AAC?) files as long as it is shown in the image placeholder.

Original comment by tmkkmac on 29 May 2013 at 3:50

GoogleCodeExporter commented 9 years ago
I mean AAC.  What I'm seeing is that cover art is indeed properly embedded in 
AAC (when transcoding from FLAC) iff it is already embedded in the FLAC.  
However, if the FLAC does not have cover art embedded before it's transcoded to 
AAC then the resulting AAC will not have embedded cover art either, even though 
the image has been successfully fetched from freedb and visible in the image 
placeholder before transcoding.  I tried several times; I'd love to be wrong 
though! :)

Original comment by maspo...@gmail.com on 29 May 2013 at 5:22

GoogleCodeExporter commented 9 years ago
As far as I've tested on my machine (10.6.8), image is embedded to the output 
files properly even if the original FLAC file does not have an embedded image.

Original comment by tmkkmac on 29 May 2013 at 7:56

GoogleCodeExporter commented 9 years ago
Oh crap (or rather, oh great!): you're right of course: I don't know how I 
convinced myself it wasn't working (on repeated trials, even!).  Thanks for 
setting me straight :)

Original comment by maspo...@gmail.com on 29 May 2013 at 7:43

GoogleCodeExporter commented 9 years ago

Original comment by tmkkmac on 30 May 2013 at 4:06