search

tsvwg / careful-resume

Careful Resume
1 stars 6 forks source link

Update labels in CDDL #24

Closed gorryfair closed 5 months ago

gorryfair commented 6 months ago

The current CDDL does not align with the specification:

OLD: previous_congestion_window: uint, previous_rtt: float32 NEW: saved_cwnd: uint, saved_rtt: float32

TheEnbyperor commented 6 months ago

This was discussed (#16) at the time of introducing CDDL and we decided the variable names should not be in short form; that is saved_congestion_window and not saved_cwnd.

gorryfair commented 6 months ago

Not quite, the words 'previous_congestion_window' do not appear, if there's strong desire for 'saved_congestion_window' that's fine with me a comment can always say this is the same as 'saved_cwnd'.

I think 'saved_rtt' is fine,

Gorry

TheEnbyperor commented 6 months ago

For consistency I'd prefer both variables to start `saved_'; and I don't think there's a point in trying to cut down on variable name lengths (at the possible detriment of ease of understanding) as QLog files are already large in size and gzip (or other) compression will deal with this fine.