tsvwg / draft-ietf-tsvwg-udp-options

0 stars 0 forks source link

NiTs on draft-ietf-tsvwg-udp-options-28 #22

Closed gorryfair closed 3 months ago

gorryfair commented 7 months ago

Erik: The typo fix for "DPLPMTUD" actually introduced another incorrect variant, "DLPMTUD". This occurs three times in draft-ietf-tsvwg-udp-options-28.txt, on the following pages:

The correct abbreviation is "DPLPMTUD":

Datagram
Packetization
Layer
Path
Maximum
Transmission
Unit
Discovery
Mike-Heard commented 7 months ago

Add to the nits: in Section 11.4, pp. 24-25, the numbering of the steps in creating a fragmented packet starts at 7 and ends at 11; it should start at 1 and end at 5. That can probably be fixed in the Word source by putting the cursor on the first item, bring up the context e=menu with right-click, and selecting "Restart at 1" as shown below. Restart-at-1

Mike-Heard commented 7 months ago

In the IANA considerations section, please change

>> Although option nicknames are not used in-band, new UNSAFE safe option names SHOULD commence with the capital letter "U" and avoid either uppercase or lowercase "U" as commencing safe options.

to

>> Although option nicknames are not used in-band, new UNSAFE option names SHOULD commence with the capital letter "U" and avoid either uppercase or lowercase "U" as commencing safe options.

I.e., s/new UNSAFE safe/new UNSAFE/.

jtouch commented 3 months ago

All fixed in -29.

Mike-Heard commented 3 months ago

All fixes look good to me.

gorryfair commented 3 months ago

Editor please define DPLPMTUD on first use: OLD: REQ/RES for DPLPMTUD [Fa23]) NEW: REQ/RES for Datagram Packetization Layer Path Maximum Transmission Unit Discovery (DPLPMTUD) [Fa22].

jtouch commented 3 months ago

fixed in pending -32 and updated to 2024 date.