tsvwg / draft-ietf-tsvwg-udp-options

0 stars 0 forks source link

Erik: Inconsistency in Security Considerations regarding not passing FRAG, NOP, and EOL to the upper layer #56

Open Mike-Heard opened 2 months ago

Mike-Heard commented 2 months ago

In https://mailarchive.ietf.org/arch/msg/tsvwg/SjPKGD-yxp2-Cf7TFGyKCCA7e8I/, Erik Auerswald wrote:

There seems to be a small inconsistency at the end of section 24, "Security Considerations":

The second to last paragraph starts with the sentence:

 "Some UDP options are never passed to the receiving application,
  notably FRAG, NOP, and EOL."

But the last paragraph of the same section uses SHOULD instead of MUST for this:

 "Such implementations SHOULD ensure FRAG, NOP, and EOL are not
  passed to the receiving user[...]"

I would expect that "SHOULD" to be a "MUST" for any implementation.

Mike-Heard commented 2 months ago

I concur that this is an error, but I would go further: since FRAG, NOP, and EOL are never passed to the receiving user/application, just change the last sentence to:

Such implementations SHOULD return options in an order not related to their sequence in the received packet.

gorryfair commented 3 days ago

@Mike-Heard This does not read correctly to me: / Such implementations SHOULD return options in an order not related to their sequence in the received packet./