Suggest to disable server logs during benchmark

tswaters / react-thread-poc

Proof of concept for offloading react server rendering to a thread.

10 stars 1 forks source link

Suggest to disable server logs during benchmark #6

Closed vjpr closed 5 years ago

vjpr commented 5 years ago

I have often found that terminal logging can impact perf, and with every request being logged it can make the terminal use more cpu.

Provide an option to disable logging, or throttle log messages like X messages received in last second.

vjpr commented 5 years ago

LOG_LEVEL=info npm start

This could be added to the readme.md.

tswaters commented 5 years ago

It can - to be honest in my work tree I have the default set there as silent and I just haven't committed it. I've added a note to the readme & set the default to silent.