tsy24 / pe

0 stars 0 forks source link

Successful addition of invalid timing for lessons #3

Open tsy24 opened 2 years ago

tsy24 commented 2 years ago

There are no checks for whether the timing for lessons is valid.

In the case of add -l n/P6 c/20 p/80 t/Monday 1200-1400p/80 which the user may have accidentally forgotten to add a spacing before p/, the p/80 is taken to be part of the timing:

image.png

It seems that invalid characters are also allowed for timings:

image.png

nus-pe-bot commented 2 years ago

Team's Response

It is expected behaviour to provide flexibility to the user when they are providing the timing for the lesson. This is stated in the User Guide.

Screenshot 2021-11-13 at 8.49.06 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]