tt-acm / EnergyAnalysisForDynamo

Dynamo <> Autodesk Green Building Studio interoperability
Other
29 stars 18 forks source link

Sign into GBS Warning #71

Closed mostaphaRoudsari closed 9 years ago

mostaphaRoudsari commented 10 years ago

"- User should be prompted to sign into GBS if they haven’t yet. o Currently, the warning for RunAnalysis.RunEnergyAnalysis if I forget to sign in is not helpful."

gbslogin

This looks like an issue with Null ProjectId and not login check but we need to test it again.

eertugrul commented 10 years ago

It seems the RunId returns null and we try to cast RunID as Integer value while de-serialization. I have add conditional check if response returns null, don't deserialize, if not null serialize and return RunId.

I like to able to add warning message when it go wrong instead throw an exception and fail to whole process. I will ask Dynamo team if it is possible.

bhowes-tt commented 9 years ago

@eertugrul - let's have another look at this one. It looks some defense on the ProjectId input is all that's needed.

eertugrul commented 9 years ago

@mostaphaRoudsari I couldn't repeat the problem !

bhowes-tt commented 9 years ago

I could, but it's a dynamo problem. The issue arises when a null is passed into the ProjectId input - our code never even executes because Dynamo can't cast a null to an Int.