tt-acm / EnergyAnalysisForDynamo

Dynamo <> Autodesk Green Building Studio interoperability
Other
29 stars 18 forks source link

Global Settings in Dynamo - Disconnected Graph #72

Open mostaphaRoudsari opened 9 years ago

mostaphaRoudsari commented 9 years ago

" That global energy model settings can be graphically disconnected from the rest of the graph that prepares the energy model is uncomfortable for some users, as it implies another layer of data—not all data is represented by the wires in the Dynamo graph. It’s a unique arrangement in the ecosystem of Dynamo so far as I’m aware. It makes sense how the nodes are written in the context of preparing a Revit energy model, but it’s not possible for the user to point to a node and understand that that node is the one that communicates with Revit. It might help to make “Energy Settings” an input to PrepareEnergyModel.CreateEnergyModelFromMassAndLevels."

This is more of a philosophical question. I'm personally a fan of having an energySettings input for create energy models but then I think it shouldn't be global. This needs to be discussed in more details.

bhowes-tt commented 9 years ago

Personally, I don't mind the disconnected graph issue. I think we tried to wrap the EnergySettings object and pass it around in Dynamo at some point early on in the development, but found we couldn't create a new instance of that class. Maybe we could create a wrapper class that can be instantiated (and passed around in Dynamo) and just points to the EnergySettings object in Revit? I'll have a look.