search

ttacon / libphonenumber

golang port of Google's libphonenumber
MIT License
618 stars 105 forks source link

Undefined protoPackageVersion #42

Closed raghav-g closed 7 years ago

raghav-g commented 8 years ago

Go get fails with this, please help :(

$ go get github.com/mattwilliamson/libphonenumber # github.com/mattwilliamson/libphonenumber ../../work/src/github.com/mattwilliamson/libphonenumber/phonemetadata.pb.go:32: undefined: proto.ProtoPackageIsVersion1

17twenty commented 7 years ago

This doesn't seem to be an issue anymore?

Can you confirm and close?

go get -u github.com/ttacon/libphonenumber
$ go test -v
=== RUN   TestParse
--- PASS: TestParse (0.00s)
=== RUN   TestConvertAlphaCharactersInNumber
--- PASS: TestConvertAlphaCharactersInNumber (0.00s)
=== RUN   Test_normalizeDigits
--- PASS: Test_normalizeDigits (0.00s)
=== RUN   Test_extractPossibleNumber
--- PASS: Test_extractPossibleNumber (0.00s)
=== RUN   Test_isViablePhoneNumer
--- PASS: Test_isViablePhoneNumer (0.00s)
=== RUN   Test_normalize
--- PASS: Test_normalize (0.00s)
=== RUN   Test_IsValidNumber
--- PASS: Test_IsValidNumber (0.00s)
=== RUN   Test_IsValidNumberForRegion
--- PASS: Test_IsValidNumberForRegion (0.00s)
=== RUN   TestFormat
--- PASS: TestFormat (0.00s)
=== RUN   Test_setItalianLeadinZerosForPhoneNumber
--- PASS: Test_setItalianLeadinZerosForPhoneNumber (0.00s)
=== RUN   Test_testNumberLengthAgainstPattern
--- PASS: Test_testNumberLengthAgainstPattern (0.00s)
=== RUN   Test_GetSupportedRegions
--- PASS: Test_GetSupportedRegions (0.00s)
=== RUN   Test_getMetadata
--- PASS: Test_getMetadata (0.00s)
=== RUN   Test_isLeadingZeroPossible
--- PASS: Test_isLeadingZeroPossible (0.00s)
=== RUN   Test_isNumberGeographical
--- PASS: Test_isNumberGeographical (0.00s)
=== RUN   TestGetLengthOfGeographicalAreaCode
--- PASS: TestGetLengthOfGeographicalAreaCode (0.00s)
=== RUN   TestGetCountryMobileToken
--- PASS: TestGetCountryMobileToken (0.00s)
=== RUN   TestGetNationalSignificantNumber
--- PASS: TestGetNationalSignificantNumber (0.00s)
=== RUN   Test_GetExampleNumberForType
--- PASS: Test_GetExampleNumberForType (0.00s)
=== RUN   TestGetExampleNumberForNonGeoEntity
--- PASS: TestGetExampleNumberForNonGeoEntity (0.00s)
=== RUN   TestNormalizeDigitsOnly
--- PASS: TestNormalizeDigitsOnly (0.00s)
=== RUN   Test_normalizeDiallableCharsOnly
--- PASS: Test_normalizeDiallableCharsOnly (0.00s)
=== RUN   TestItalianLeadingZeroes
--- PASS: TestItalianLeadingZeroes (0.00s)
=== RUN   TestARNumberTransformRule
--- PASS: TestARNumberTransformRule (0.00s)
=== RUN   TestLeadingOne
--- PASS: TestLeadingOne (0.00s)
=== RUN   TestNewIndianPhones
--- PASS: TestNewIndianPhones (0.00s)
=== RUN   TestGetTimeZonesForRegion
--- PASS: TestGetTimeZonesForRegion (0.00s)
PASS
ok      github.com/ttacon/libphonenumber    0.062s
ttacon commented 7 years ago

Closing since there wasn't a response to the last comment.