search

ttadano / ALM

MIT License
18 stars 9 forks source link

Work in Fitting, Displace, Fcs, Constraint classes #17

Closed atztogo closed 6 years ago

atztogo commented 6 years ago

Public variables of the four classes in the title were moved to private. Most of changes were trivial.

I will not work for Lasso class for some time to come. So I feel I have somehow finished the move of public variables to private for important classes. These are mostly just non-intelligent replacements of public variables to getters and setters, so no consideration of design.

Now we stand at the starting point to consider the design of the code. Already ALM relies on C++11, so the code can be updated following the C++11 way every time when touching the code.

ttadano commented 6 years ago

This version seems to work correctly. Thank you so much for the whole changes.

I'm now merging the Fitting and Lasso classes on the feature/refactor_lasso branch, so we will not have to work on the Lasso class separately. After merging this PR with develop, I'll merge develop with feature/refactor_lasso, fix conflicts, and then merge the changes in feature/refactor_lasso with develop. I expect to finish it within a few days. Thanks.