search

ttag-org / ttag

:orange_book: simple approach for javascript localization
https://ttag.js.org/
MIT License
345 stars 43 forks source link

fix(types): Upgrade dtslint and remove react typings #140

Closed erickwilder closed 5 years ago

erickwilder commented 5 years ago

After upgrading dtslint to the latest version I got some errors with a missing csstype package. We are not using any react-specific typings (there was in fact an unused import) and after removing it I could get rid of @types/react baked in the library

This should close #136

codecov[bot] commented 5 years ago

Codecov Report

Merging #140 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files           4        4           
  Lines         471      471           
  Branches       70       70           
=======================================
  Hits          456      456           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7881674...7fa8b2b. Read the comment docs.

AlexMost commented 5 years ago

:tada: great thanks!