Movie Results - Githubissues

ttakahashi1591 / viewing_party_lite

0 stars 1 forks source link

Movie Results #18

Closed Sykogst closed 11 months ago

Sykogst commented 11 months ago

Description

This PR will add information to results page of filtered top rated page AND search page

Title of movie as link to display page (had to remove :url from link_to form on view
Vote Average rounded to one decimal
Tests to ensure there are no more than 20 results per page
Added some instance variables on Movie poro

Take an extra look at

IDs in the spec file are hard coded, could not think of a way to grab the IDs from the movie API poros
This was used in expected end paths from clicking on a movie title link and within blocks to make sure vote averages are properly paired
Could expand testing to include more than one movie

Type of Change

[ ] fix
[x] feat
[x] test
[ ] refactor
[ ] docs

Checklist

[x] Code has been self reviewed
[x] Code runs without any errors
[x] Thorough testing has been implemented if adding feature
[x] All tests pass